Commit Graph

1012 Commits

Author SHA1 Message Date
neil
ce629e8e70 fix typo 2023-03-04 21:23:31 +08:00
neil
20cfc4ac66 fix https://github.com/acmesh-official/acme.sh/issues/4535 2023-03-04 21:22:17 +08:00
neilpang
cb8b341fb4 fix https://github.com/acmesh-official/acme.sh/issues/4530 2023-03-02 18:10:38 +08:00
neilpang
982c54b605 fix https://github.com/acmesh-official/acme.sh/issues/4530 2023-03-02 18:06:09 +08:00
Markus Hoffrogge
15f96b7239 Fix to handle LE overload status 503 appropriately
- LE HTTP response status 503 is not an error, it must be handled via sleep and retry
- s. https://community.letsencrypt.org/t/new-service-busy-responses-beginning-during-high-load/184174

fixes #4530
2023-03-02 00:46:52 +01:00
neilpang
a5fbf3fb80 fix format 2023-02-03 09:59:42 +08:00
neilpang
3cf8f78745 fix format 2023-02-03 09:57:56 +08:00
neilpang
59dab6eac7 fix https://github.com/acmesh-official/acme.sh/issues/4485#issuecomment-1414022376
https://github.com/acmesh-official/acme.sh/issues/4483#issuecomment-1414460122
2023-02-03 09:55:51 +08:00
neilpang
c2344f3717 add log for doh
https://github.com/acmesh-official/acme.sh/issues/4481
2023-01-30 14:39:03 +08:00
neil
c2ad1b4e46
Merge pull request #4448 from PMExtra/feature/curl_fail
curl return fail if HTTP errors
2023-01-28 20:37:20 +08:00
PMExtra
a5b04a0328 ensure curl --help backward compatible 2023-01-28 17:19:04 +08:00
neil
015a9b9271 fix notify 2023-01-24 16:45:12 +08:00
neil
b99c998057 fix https://github.com/acmesh-official/acme.sh/issues/4463 2023-01-24 16:13:42 +08:00
neil
6c0a7144f6 fix https://github.com/acmesh-official/acme.sh/issues/4445 2023-01-24 15:45:25 +08:00
neil
bf50fce5bd fix https://github.com/acmesh-official/acme.sh/issues/4470 2023-01-24 15:17:48 +08:00
neil
a2c64e79ff fix for openbsd 2022-12-26 22:28:08 +08:00
PMExtra
7154c9ee5d improve curl --help predication 2022-12-23 17:42:27 +08:00
PMExtra
057c95bd1c improve wget --content-on-error condition 2022-12-23 17:39:51 +08:00
PMExtra
0cafc00c4f append --fail-with-body argument to curl if supported 2022-12-23 17:22:12 +08:00
neil
75d2898efd
Merge pull request #4441 from plummer86/bugfix/_wget_out_fix
Fix assignment: _wget_out
2022-12-19 10:23:00 +08:00
plummer86
764a4c99fa Fix assignment to _wget_out 2022-12-18 22:32:49 +00:00
neil
a2af26635f use ecc cert 2022-12-04 15:05:30 +08:00
neil
63869deeb2
Merge pull request #4091 from PMExtra/feature/ssh_scp
Refact ssh hook to use deploy config, support scp and support specifying port
2022-12-03 13:58:31 +08:00
neil
a19f7481b2
Merge pull request #4410 from kirisakow/patch-1
Trim trailing slash in `--home` argument's value from the get-go to avoid that subsequently created paths contain two adjacent slashes in the middle
2022-11-28 09:58:46 +08:00
Kiril Isakov
264b9819ff
Replace the BASH parameter substitution mechanism (unsupported by sh) with standard commands (supported by sh) 2022-11-27 09:22:06 +01:00
Kiril Isakov
9f942a6b65
Trim trailing slash in --home argument's value
# What's expected

Since in `acme.sh` path strings are concatenated with a hardcoded slash in between, the left operand must never end with a trailing slash for the resulting path to be valid. Otherwise, obviously, the resulting path will have two adjacent slashes in the middle and will not be valid.

# What actually happens

Even though I cannot tell for each of the input params, I know this for sure for the the `--home` argument's value.

If I run `acme.sh` with `--home` argument's value being a path ending in a trailing slash,

```sh
acme.sh ... --debug ... --home /some/path/ ... -d somedomainna.me ...
```

I get the following (distinct) occurrencies of resulting invalid paths containing two adjacent slashes:

```
[...] Using config home:/some/path/

[...] DOMAIN_PATH='/some/path//somedomainna.me'

[...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g '

[...] The domain key is here: /some/path//somedomainna.me/somedomainna.me.key

[...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g  -I  '

[...] Your cert is in: /some/path//somedomainna.me/somedomainna.me.cer

[...] Your cert key is in: /some/path//somedomainna.me/somedomainna.me.key

[...] The intermediate CA cert is in: /some/path//somedomainna.me/ca.cer

[...] And the full chain certs is there: /some/path//somedomainna.me/fullchain.cer

```

# Suggested fix

Trim trailing slash in `--home` argument's value from the get-go.
2022-11-26 16:00:03 +01:00
neil
ec0e871592 Use ec-256 as default key length
fix https://github.com/acmesh-official/acme.sh/issues/2350#issuecomment-1324029469
2022-11-23 21:57:38 +08:00
neil
7a756ebc4d start v3.0.6 2022-11-23 21:55:19 +08:00
neil
c9a55f395b fix doh
https://github.com/acmesh-official/acme.sh/issues/4369
2022-10-29 10:08:42 +08:00
neil
1c16931e26 add Le_Next_Domain_Key for tlsa
fix https://github.com/acmesh-official/acme.sh/issues/3096
Usage: https://github.com/acmesh-official/acme.sh/wiki/tlsa-next-key
2022-10-16 16:06:01 +08:00
Adam Tao
666c716bda Fix error during saving conf
There might be '|' in __val (e.g., SYNO_Password), which will cause that
all content of the conf file is cleared. Fix it by escaping '|'
manually.

Signed-off-by: Adam Tao <tcx4c70@gmail.com>
2022-10-11 20:45:31 +08:00
neil
be477d7ae3
Merge pull request #4259 from Mon-ius/master
fix a issue, when profile not end with newline
2022-10-05 14:20:01 +08:00
neil
f8ca6d9833 fix https://github.com/acmesh-official/acme.sh/issues/1335 2022-10-05 13:14:25 +08:00
neil
dbab519004
Merge pull request #4252 from agowa338/agowa338-patch-1
Fix missing HTTP_HEADER for _get with wget
2022-10-04 11:20:12 +08:00
neilpang
d761bdc1b1 minor, just indent usage 2022-09-30 18:03:47 +08:00
Klaus Frank
41dbf1ddac
use _contains instead of grep 2022-09-27 22:47:35 +02:00
neil
dd207e1f02 fix https://github.com/acmesh-official/acme.sh/issues/4285 2022-09-24 22:00:39 +08:00
Klaus Frank
c2a7e384ba
Fix linting issue 2022-09-18 22:03:52 +02:00
Klaus Frank
4a8b35ef5f
Merge branch 'acmesh-official:master' into agowa338-patch-1 2022-09-18 22:00:49 +02:00
neil
0a47f48191 fix https://github.com/acmesh-official/acme.sh/issues/4301 2022-09-08 22:09:39 +08:00
neil
8601267b90 fix https://github.com/acmesh-official/acme.sh/issues/4301 2022-09-08 21:56:49 +08:00
Klaus Frank
864315f6d1 Use literal space
Replace [[:space:]] with " "
2022-08-24 19:34:37 +02:00
Klaus Frank
713b7338ea demultiplex wget debug output 2022-08-24 19:34:37 +02:00
Klaus Frank
53117b2f4c Fix missing HTTP_HEADER for _get with wget
Save http header to file for _get with wget.
2022-08-24 19:34:36 +02:00
Monius
b95f836256 final try 2022-08-23 06:30:09 +08:00
Monius
5a604bfdee shfmt check? 2022-08-22 15:16:30 +08:00
Monius
6502a71083 fix, but remove debug info 2022-08-22 05:26:12 +08:00
Monius
f2634b44cd add EOF, if $__conf not end with one 2022-08-21 12:26:37 +08:00
Monius
dcf9c467c3 fix issue, when profile not end with newline 2022-08-20 19:37:51 +08:00
neil
7169060425 fix https://github.com/acmesh-official/acme.sh/issues/4248#issuecomment-1217378906 2022-08-20 10:54:17 +08:00