plantroon/acme.sh
1
0
Fork 0
mirror of https://github.com/plantroon/acme.sh.git synced 2024-12-27 23:41:45 +00:00
Code Issues Projects Releases Wiki Activity
5,160 Commits 5 Branches 23 Tags 6.7 MiB
97f87c4229
Commit Graph

5160 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kiril Isakov
9f942a6b65
Trim trailing slash in --home argument's value 
# What's expected

Since in `acme.sh` path strings are concatenated with a hardcoded slash in between, the left operand must never end with a trailing slash for the resulting path to be valid. Otherwise, obviously, the resulting path will have two adjacent slashes in the middle and will not be valid.

# What actually happens

Even though I cannot tell for each of the input params, I know this for sure for the the `--home` argument's value.

If I run `acme.sh` with `--home` argument's value being a path ending in a trailing slash,

```sh
acme.sh ... --debug ... --home /some/path/ ... -d somedomainna.me ...
```

I get the following (distinct) occurrencies of resulting invalid paths containing two adjacent slashes:

```
[...] Using config home:/some/path/

[...] DOMAIN_PATH='/some/path//somedomainna.me'

[...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g '

[...] The domain key is here: /some/path//somedomainna.me/somedomainna.me.key

[...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g  -I  '

[...] Your cert is in: /some/path//somedomainna.me/somedomainna.me.cer

[...] Your cert key is in: /some/path//somedomainna.me/somedomainna.me.key

[...] The intermediate CA cert is in: /some/path//somedomainna.me/ca.cer

[...] And the full chain certs is there: /some/path//somedomainna.me/fullchain.cer

```

# Suggested fix

Trim trailing slash in `--home` argument's value from the get-go.
 2022-11-26 16:00:03 +01:00
Arash Hatami
f4ed1b32b8
Update dns_arvan.sh 
Update API URL
 2022-11-26 18:12:11 +03:30
neil
ec0e871592 Use ec-256 as default key length 
fix https://github.com/acmesh-official/acme.sh/issues/2350#issuecomment-1324029469
 2022-11-23 21:57:38 +08:00
neil
7a756ebc4d start v3.0.6 2022-11-23 21:55:19 +08:00
neil
16dc21afff
Merge pull request #4406 from acmesh-official/dev 
sync
 2022-11-23 21:44:53 +08:00
neil
3a1c6d84f0 fix shellcheck warnings 2022-11-23 21:40:34 +08:00
neil
e684abdacd fix checkout 2022-11-23 21:34:58 +08:00
neil
e275cb1efd fix shellcheck warnings 2022-11-23 21:33:29 +08:00
neil
60315e5b91 fix shellcheck warnings 2022-11-23 21:28:17 +08:00
neil
43b1a4bf5a
Merge pull request #4405 from acmesh-official/dev 
sync
 2022-11-23 21:16:44 +08:00
neil
cdb238e41c fix cf-tunnel 2022-11-23 21:12:52 +08:00
neil
3871e44d9c
Merge pull request #4400 from waja/docker_alpine_update 
Docker alpine update
 2022-11-20 19:47:44 +08:00
Jan Wagner
5a51454d13 Update Alpine to 1.16.3 
With #4399 applied we can pick minor versions safely.
 2022-11-17 15:20:11 +01:00
neil
d102943a32 upgrade actions/checkout@v3 2022-11-07 22:36:40 +08:00
neil
a0b27ddbd8
Merge pull request #4372 from PeterDaveHello/speedup-ci 
Reduce `acmetest` `git clone` depth to speed up CI pipeline
 2022-10-29 13:59:32 +08:00
neil
b950b04e89
Merge pull request #4371 from PeterDaveHello/use-https 
Use encrypted https instead of plain-text http when we can
 2022-10-29 13:58:20 +08:00
neil
c9a55f395b fix doh 
https://github.com/acmesh-official/acme.sh/issues/4369
 2022-10-29 10:08:42 +08:00
Peter Dave Hello
424da01878 Reduce acmetest git clone depth to speed up CI pipeline 2022-10-27 19:49:10 +08:00
Peter Dave Hello
3c933158c8 Use encrypted https instead of plain-text http when we can 2022-10-27 19:45:48 +08:00
neil
7221d488e5
Merge pull request #4365 from acmesh-official/dev 
sync
 2022-10-24 17:44:22 +08:00
neil
1c16931e26 add Le_Next_Domain_Key for tlsa 
fix https://github.com/acmesh-official/acme.sh/issues/3096
Usage: https://github.com/acmesh-official/acme.sh/wiki/tlsa-next-key
 2022-10-16 16:06:01 +08:00
neil
0a4b70dbd2
Merge pull request #4349 from tcx4c70/fix/save-conf 
Fix error during saving conf
 2022-10-12 08:17:08 +08:00
Adam Tao
666c716bda Fix error during saving conf 
There might be '|' in __val (e.g., SYNO_Password), which will cause that
all content of the conf file is cleared. Fix it by escaping '|'
manually.

Signed-off-by: Adam Tao <tcx4c70@gmail.com>
 2022-10-11 20:45:31 +08:00
neil
be477d7ae3
Merge pull request #4259 from Mon-ius/master 
fix a issue, when profile not end with newline
 2022-10-05 14:20:01 +08:00
neil
6c8a623b88
Merge pull request #4329 from lippertmarkus/patch-1 
[Deploy: synology_dsm] Make usage of DID with 2FA working for DSM 7
 2022-10-05 14:18:37 +08:00
neil
ff8de34415
Merge pull request #4335 from acmesh-official/dev 
sync
 2022-10-05 14:17:03 +08:00
neil
f8ca6d9833 fix https://github.com/acmesh-official/acme.sh/issues/1335 2022-10-05 13:14:25 +08:00
neil
dbab519004
Merge pull request #4252 from agowa338/agowa338-patch-1 
Fix missing HTTP_HEADER for _get with wget
 2022-10-04 11:20:12 +08:00
neil
e888c96591
Merge pull request #4331 from arnebjarne/dns_cpanel_newserial_fix 
Dns cpanel newserial fix
 2022-10-02 20:40:50 +08:00
neil
59519f0493
Merge pull request #4334 from sasburg/patch-1 
Added parked_domans
 2022-10-02 20:39:52 +08:00
sasburg
e02f07d356
add parked_domans 2022-10-01 18:11:46 -07:00
sasburg
2c90d220b8
Updated comment to reflect the change to function 2022-10-01 17:47:13 -07:00
Bjarne Saltbaek
9feeba8d4b Forgot to apply the changed default return value 2022-10-01 15:19:02 +02:00
Bjarne Saltbaek
45090fc897 Better way to catch success or failure 2022-10-01 14:58:12 +02:00
neilpang
d761bdc1b1 minor, just indent usage 2022-09-30 18:03:47 +08:00
neil
287a8c76b5
Merge pull request #4328 from srirams/srirams-patch-1 
Add addon domains to cpanel_uapi
 2022-09-30 17:15:22 +08:00
Markus Lippert
a7dd86de71
fix(deploy-synology_dsm): support DID with DSM 7 2022-09-29 12:22:45 +02:00
srirams
c541a2e5de
add addon_domans 2022-09-28 18:22:13 -05:00
Klaus Frank
41dbf1ddac
use _contains instead of grep 2022-09-27 22:47:35 +02:00
neil
70ed6b96d1
Merge pull request #4317 from acmesh-official/dev 
sync
 2022-09-25 00:02:58 +08:00
neil
ef26075a1c export TokenName 2022-09-24 23:58:56 +08:00
neil
91c87446be
Merge pull request #4115 from koter84/dev 
make ip-whitelisting configurable for DNS TransIP
 2022-09-24 23:31:29 +08:00
neil
dd207e1f02 fix https://github.com/acmesh-official/acme.sh/issues/4285 2022-09-24 22:00:39 +08:00
neil
e947870da9 minor 2022-09-23 22:39:53 +08:00
neil
f0b5f592dc
Merge pull request #4310 from mystix/patch-1 
Prevent erasure of saved access token on DNS removal
 2022-09-20 21:46:19 +08:00
Marc
773a2a6cfe Merge branch 'master' into patch-1 2022-09-19 13:08:07 +08:00
Klaus Frank
c2a7e384ba
Fix linting issue 2022-09-18 22:03:52 +02:00
Klaus Frank
4a8b35ef5f
Merge branch 'acmesh-official:master' into agowa338-patch-1 2022-09-18 22:00:49 +02:00
neil
5cd0db32df
Merge pull request #4256 from dannytix/cpanel_auto 
Cpanel auto
 2022-09-18 20:52:11 +08:00
neil
ef01de6149
Merge pull request #4313 from acmesh-official/dev 
sync
 2022-09-18 20:25:26 +08:00