From a8c61111978013d594d63cca7e6eadab1e865bad Mon Sep 17 00:00:00 2001 From: neilpang Date: Sat, 12 Nov 2016 11:45:30 +0800 Subject: [PATCH] fix shellcheck warnings --- dnsapi/dns_lexicon.sh | 8 ++++---- dnsapi/dns_lua.sh | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dnsapi/dns_lexicon.sh b/dnsapi/dns_lexicon.sh index d3bfc942..4ab65645 100755 --- a/dnsapi/dns_lexicon.sh +++ b/dnsapi/dns_lexicon.sh @@ -31,7 +31,7 @@ dns_lexicon_add() { export PROVIDER Lx_name=$(echo LEXICON_"${PROVIDER}"_USERNAME | tr '[a-z]' '[A-Z]') - Lx_name_v=$(eval "echo "\$"$Lx_name""") + Lx_name_v=$(eval echo \$"$Lx_name") _debug "$Lx_name" "$Lx_name_v" if [ "$Lx_name_v" ]; then _saveaccountconf "$Lx_name" "$Lx_name_v" @@ -39,7 +39,7 @@ dns_lexicon_add() { fi Lx_token=$(echo LEXICON_"${PROVIDER}"_TOKEN | tr '[a-z]' '[A-Z]') - Lx_token_v=$(eval "echo "\$"$Lx_token""") + Lx_token_v=$(eval echo \$"$Lx_token") _debug "$Lx_token" "$Lx_token_v" if [ "$Lx_token_v" ]; then _saveaccountconf "$Lx_token" "$Lx_token_v" @@ -47,7 +47,7 @@ dns_lexicon_add() { fi Lx_password=$(echo LEXICON_"${PROVIDER}"_PASSWORD | tr '[a-z]' '[A-Z]') - Lx_password_v=$(eval "echo "\$"$Lx_password""") + Lx_password_v=$(eval echo \$"$Lx_password") _debug "$Lx_password" "$Lx_password_v" if [ "$Lx_password_v" ]; then _saveaccountconf "$Lx_password" "$Lx_password_v" @@ -55,7 +55,7 @@ dns_lexicon_add() { fi Lx_domaintoken=$(echo LEXICON_"${PROVIDER}"_DOMAINTOKEN | tr '[a-z]' '[A-Z]') - Lx_domaintoken_v=$(eval "echo "\$"$Lx_domaintoken""") + Lx_domaintoken_v=$(eval echo \$"$Lx_domaintoken") _debug "$Lx_domaintoken" "$Lx_domaintoken_v" if [ "$Lx_domaintoken_v" ]; then eval export "$Lx_domaintoken" diff --git a/dnsapi/dns_lua.sh b/dnsapi/dns_lua.sh index e6b48724..2c7ec4b3 100755 --- a/dnsapi/dns_lua.sh +++ b/dnsapi/dns_lua.sh @@ -18,6 +18,8 @@ dns_lua_add() { txtvalue=$2 if [ -z "$LUA_Key" ] || [ -z "$LUA_Email" ]; then + LUA_Key="" + LUA_Email="" _err "You don't specify luadns api key and email yet." _err "Please create you key and try again." return 1